Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed default for max_throughput #9282

Merged
merged 1 commit into from
Jun 2, 2021
Merged

fixed default for max_throughput #9282

merged 1 commit into from
Jun 2, 2021

Conversation

modular-magician
Copy link
Collaborator

Fixes #9228

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vpcaccess: fixed permadiff when `max_throughput` is not set on `google_vpc_access_connector`

Derived from GoogleCloudPlatform/magic-modules#4823

@modular-magician
fixed default for max_throughput (hashicorp#4823)
09d5687 
* fixed default for max_throughput

* updated a test

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Jun 2, 2021
@modular-magician modular-magician merged commit ab7d328 into hashicorp:master Jun 2, 2021
@ahmetb ahmetb mentioned this pull request Jun 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
@modular-magician modular-magician deleted the downstream-pr-bd32c20b5276fd5b4634f8d9784ec98f2877c9c4 branch November 17, 2024 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_vpc_access_connector getting redeployed on every terraform apply without changes in configuration
1 participant
@modular-magician